-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubeedge Local Up Scirpt Guide #600
Conversation
This pr is to add a script guide for Kubeedge local up which requested in: #433 |
d4a48ee
to
b6946ff
Compare
docs/developer/local_up_kubeedge.md
Outdated
5. Shutting Down the Cluster: | ||
If the cluster is no longer needed, you can use the cleanup function provided in the script to stop and clean up the cluster and related resources. | ||
|
||
```shell | ||
cleanup | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a note: Users can directly use ctrl+c to terminate the script and call the cleanup function to clean up the environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified shutting down parts.
|
||
3. Container Runtime Installation: | ||
|
||
Based on the user's choice of container runtime (docker, cri-o, isulad), the script attempts to install the corresponding runtime tools. | ||
Checks and verifies the installation of Go language version, kubectl tool, and kind tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to mention here that if the user does not set the container runtime, we will use containerd by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add note that containerd will be set by default.
docs/developer/local_up_kubeedge.md
Outdated
```shell | ||
healthcheck | ||
kubectl get nodes | grep edge-node | grep -q -w Ready && break | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, healthcheck is generally only used inside scripts. Users can directly check the kubeedge node status through the k8s API, so I recommend deleting healthcheck here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed that part in the usage steps, and mentioned in the script analysis that user could use k8s API to check the health status.
c95db7a
to
570dd33
Compare
docs/developer/local_up_kubeedge.md
Outdated
```shell | ||
hack/local_up_kubeedge.sh | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name of script is local-up-kubeedge.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct the script name
docs/developer/local_up_kubeedge.md
Outdated
|
||
1. Set environment variables | ||
|
||
This script sets several environment variables at the beginning, including log directory, log level, timeout duration, protocol type, container runtime type, Kebenetes cluster name and etc. This is the necessary for local Kebeedge cluster setting up and starting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script sets several environment variables at the beginning, including log directory, log level, timeout duration, protocol type, container runtime type, Kebenetes cluster name and etc. This is the necessary for local Kebeedge cluster setting up and starting. | |
This script sets several environment variables at the beginning, including log directory, log level, timeout duration, protocol type, container runtime type, Kubernetes cluster name and etc. This is the necessary for local KubeEdge cluster setting up and starting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct the name
39d65fd
to
258cbad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
docs/developer/local_up_kubeedge.md
Outdated
@@ -0,0 +1,170 @@ | |||
--- | |||
title: Kubeedge Local Up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Kubeedge Local Up | |
title: KubeEdge Local Up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified.
Signed-off-by: Xue Mingdi <[email protected]>
628c4c4
to
dd66596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Shelley-BaoYue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) this PR fixes:
#433
Fixes #
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
N.A
What is the new behavior (if this is a feature change)?
Add Kubeedge Local Upgrade Scirpt Guide
Umbrella Issue for KubeEdge Documentation Improvement #433
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: